This repository has been archived by the owner on Oct 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grenzr
force-pushed
the
assorted_improvements
branch
from
October 5, 2018 15:06
3f24d58
to
98a7744
Compare
@grenzr Please rebase to master |
@grenzr Thanks for your PR. It might take a while to test your changes. |
Hi @vglafirov I will look at rebasing shortly |
This allows you to specify additional custom pod volumes and vsts-agent container volumeMounts in the deployment
Allows you to sidecar additional containers in the vsts-agent pod
Don't really need helm- in the name? make helm-packge requires chart name to be same as chart dir name
grenzr
force-pushed
the
assorted_improvements
branch
from
November 7, 2018 14:42
ae17b64
to
19d76f1
Compare
Ok, its rebased now, but the 1.0.0 tgz doesn't currently contain the storageclass changes.. I could do it as part of the PR if you like (since I've put one there in this PR), but I think going forward it would probably be best you cut your own tgz's after merging 1 or many PRs when you're ready to declare a new release. |
I have another commit behind this, in a different branch, which allows you to provide your own additional volumeClaimTemplates too. Can pull it in this PR too if you want? (This also has a newly built 1.0.0 tgz) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds quite a few bits of new functionality and refactor (some of which might be a step too far for you, but I thought I'd give it a go anyway :)
helm repo add vsts-agent https://raw.githubusercontent.com/grenzr/helm-vsts-agent/assorted_improvements/charts/
to pull in the repo)Our example use is to sidecar our own docker DIND image instead of using the k8s hosts docker service (which imo is not a good approach). This way guarantees consistency from k8s deployment to deployment :